https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561
--- Comment #12 from Kyle M Hall <k...@bywatersolutions.com> --- Comment on attachment 73064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73064 Bug 17561 - ReserveSlip needs itemnumber for item level holds on same biblio Review of attachment 73064: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17561&attachment=73064) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +1857,4 @@ > > =head2 ReserveSlip > > + ReserveSlip($args => { This description doesn't reflect how to actually call the sub now ( using a hashref ). Please update. @@ +1886,5 @@ > + my $hold; > + if ($args->{itemnumber}) { > + $hold = Koha::Holds->search({biblionumber => $args->{biblionumber}, > borrowernumber => $args->{borrowernumber}, itemnumber => $args->{itemnumber} > })->next; > + } elsif ($args->{barcode}) { > + my $itemnumber = Koha::Items->find({ barcode => $args->{barcode} }); $itemnumber is never used @@ +1888,5 @@ > + $hold = Koha::Holds->search({biblionumber => $args->{biblionumber}, > borrowernumber => $args->{borrowernumber}, itemnumber => $args->{itemnumber} > })->next; > + } elsif ($args->{barcode}) { > + my $itemnumber = Koha::Items->find({ barcode => $args->{barcode} }); > + if ($args->{itemnumber}) { > + $hold = Koha::Holds->search({biblionumber => > $args->{biblionumber}, borrowernumber => $args->{borrowernumber}, itemnumber > => $args->{itemnumber} })->next; this makes no sense. This is exactly the same call is if(itemnumber) but is inside "if barcode && itemnumber" but barcode is never used -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
