https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #31 from Jon Knight <j.p.kni...@lboro.ac.uk> ---
(In reply to Katrin Fischer from comment #30)
> Hi Jon, if QA demands a follow-up what you can usually do is make a small
> extra patch with the additional changes and attach it. In this case it would
> have just been removing the attribute. This way you can keep the sign-off on
> your first patch and the signed-off status and it goes directly back to QA.
> Do you want to change it and restore the signed off patch with a little
> addition?

No, because the last patch changed the behaviour (again), rather than just
being a small change to get rid of the commented out line.  That really needs
someone to check that it is what people actually want and sign that off
(again).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to