Tomás Cohen Arazi <> changed:

           What    |Removed                     |Added
  Attachment #73824|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <> ---
Created attachment 73914
Bug 20540: Fix TransformHtmlToXml if last tag is empty

This bug has been found during testing bug 19289.

In some conditions C4::Biblio::TransformHtmlToXml will generate a malformed XML
structure. The last </datafield> can be duplicated.

For instance, if a call like:
my $xml = TransformHtmlToXml( \@tags, \@subfields, \@field_values );

with the last value of @field_values is empty, it will return:

<?xml version="1.0" encoding="UTF-8"?>
<datafield2 tag="020" ind1=" " ind2=" ">
<subfield code="a">l</subfield>
<datafield1 tag="100" ind1=" " ind2=" ">
<subfield code="a">k</subfield>
<datafield1 tag="245" ind1=" " ind2=" ">
<subfield code="a">k</subfield>
<datafield1 tag="250" ind1=" " ind2=" ">
<subfield code="a">k</subfield>
<datafield1 tag="260" ind1=" " ind2=" ">
<subfield code="b">k</subfield>
<subfield code="c">k</subfield>

Which will result later in the following error:
:23: parser error : Opening and ending tag mismatch: record line 6 and
:24: parser error : Opening and ending tag mismatch: collection line 2 and
:25: parser error : Extra content at the end of the document

Test plan:
You can test it along with bug 19289 and confirm that it fixes the problem
raised on bug 19289 comment 30

Signed-off-by: Katrin Fischer <>
Signed-off-by: Tomas Cohen Arazi <>

You are receiving this mail because:
You are watching all bug changes.
Koha-bugs mailing list
website :
git :
bugs :

Reply via email to