https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969
--- Comment #16 from David Gustafsson <[email protected]> --- > I don't think I actually follow you here - we still specify different > analyzers > per field, but we also construct the _all field and use that for keyword > searching only - this is what we currently do. So we can search specific > fields, or use the all. My point was with regards to this line: https://github.com/Koha-Community/Koha/blob/master/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm#L93 where default_field is set to '_all', and in the patch this is changed to '_all_fields'. If searching for some terms (without specifying specific fields in the search string), the default_field will be used, 'all_fields' in this case, and no field-specific analyzers will be used. If instead setting "fields" to all relevant fields, the field-specific analyzers etc will be applied. > The only downside is listing all the fields individually so a small cost in > construction of queries and query size, but not terrible I would think Yes, you are correct. The query construction overhead is insignificant, but it will incur a slightly higher cost executing the query as multiple fields will be queried instead of just one. But I still don't see using just one field as an option since this would make most of the nice Elasticsearch free text search features impossible to implement. > Looking forward to it! :-) - have you seen bug 18316? > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Damn, must have missed that one. They are still slightly incompatible so perhaps still would have needed to re-implement field boosts (as the new patch always uses the "field" parameter with possible boosts, not just for boosted fields). I created a new issue for my suggestion regarding remove the "_all" field and field boosts: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
