https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #46 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Starting with a code review, patches apply, QA script passes: 1) Translatability issue + <h3>Are you sure delete <b> [% serialnumber %] </b> selected serials</h3> Please rethink this sentence. The <b> should not be used within a sentence as it will break this into several strings. I think it's not necessary here. Also sentence reads a bit strangely? :) Similar here: <h5>Number of items available <b>: [% countitems %] </b> </h5> That went well! Now testing: 2) I think if the serial is not set up to create items, we should not ask. Or if the number of items is 0. 3) A checkbox for deleting items would be a little nicer than the radio button. Could be fixed later, not blocker. 4) Number of items available : 0 No space there in English: available: 5) The appearing yellow dialogue pushes down the navigation bar on the right. Please check. Mostly tiny stuff, this looks quite good. Can you provide a quick follow-up and switch back to signed-off please? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/