https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592
--- Comment #6 from David Cook <[email protected]> --- (In reply to M. Tompsett from comment #2) > I believe this is the wrong way to do it. The problem is ModItem requires an > itemnumber, and the itemnumber check is too late in the function. No, that's not the problem. The problem is an an empty $item hashref being passed into C4::Items::_koha_modify_item(), which creates an invalid SQL query. But I agree that a better solution would be to change ModItem rather than updateitem.pl. I considered that, but I figured I would make the lightest touch possible and test the one place where I knew there was a problem. Do you know whether or not it's appropriate to return early from ModItem? What impact does that have across Koha? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
