https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64728|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <[email protected]> --- Comment on attachment 64728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64728 Alternate patch which preserves status quo on biblio vs. item-level itemtypes >From a971568d84bb64f5e1cdefda13192fac2653695f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <[email protected]> >Date: Thu, 15 Jun 2017 12:32:43 +0000 >Subject: [PATCH] Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons > >If item-level_itypes is turned off and XSLTResultsDisplay is turned on, >biblio-level itemtype images are not shown in staff client search >results. This patch corrects the problem. > >This patch also adds some markup and CSS to the itemtype image to make >it look a litte cleaner and work better in result sets in which some >titles have images and some don't. > >To test, apply the patch and view the staff client search results page >with various settings: > >- XSLT turned on and off >- item-level_itypes turned on and off >- noItemTypeImages turned on and off > >Confirm that item type images are shown or not shown correctly according >to each setting. > >The difference between this patch and the other patch currently on this >bug is that this patch continues the practice of hiding biblio-level >itemtype information when item-level_itypes is ON. >--- > koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 14 ++++++++++++ > .../prog/en/modules/catalogue/results.tt | 25 ++++++++++------------ > 2 files changed, 25 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >index fb09d51..6d37ce3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >@@ -3007,3 +3007,17 @@ fieldset.rows + fieldset.action { > #patron_search #filters { > display: none; > } >+ >+.result-biblio-itemtype { >+ float: right; >+ padding: .5em; >+ margin: .5em; >+ font-size: 85%; >+ text-align: center; >+} >+ >+.result-biblio-itemtype img { >+ display: block; >+ margin: auto; >+ margin-bottom: 2px; >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index e035200..a8e8f44 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -529,6 +529,16 @@ var holdForPatron = function () { > <input type="checkbox" class="selection" > id="bib[% SEARCH_RESULT.biblionumber %]" name="biblionumber" value="[% > SEARCH_RESULT.biblionumber %]" style="display:none" /> > </td> > <td> >+ >+ [% UNLESS ( item_level_itypes ) %] >+ <div class="result-biblio-itemtype"> >+ [% IF !noItemTypeImages && >SEARCH_RESULT.imageurl %] >+ <img src="[% >SEARCH_RESULT.imageurl %]" alt="[% SEARCH_RESULT.description %]" /> >+ [% END %] >+ [% SEARCH_RESULT.description %] >+ </div> >+ [% END %] >+ > [% IF ( SEARCH_RESULT.XSLTResultsRecord ) %] > [% SEARCH_RESULT.result_number %]. > [% SEARCH_RESULT.XSLTResultsRecord %] >@@ -549,22 +559,9 @@ var holdForPatron = function () { > [% ELSE %] > > [% END %] >- <p> >- [% UNLESS ( item_level_itypes ) %] >- [% IF !noItemTypeImages && >SEARCH_RESULT.imageurl %] >- <img src="[% SEARCH_RESULT.imageurl %]" >title="[% SEARCH_RESULT.description %]" style="float: left; margin: .1em;" >alt="[% SEARCH_RESULT.description %]" /> >- [% END %] >- [% SEARCH_RESULT.description %] >- [% END %] >- [% SEARCH_RESULT.summary %]</p> >+ <p>[% SEARCH_RESULT.summary %]</p> > [% ELSE %] > <p> >- [% UNLESS ( item_level_itypes ) %] >- [% IF !noItemTypeImages && >SEARCH_RESULT.imageurl %] >- <img src="[% SEARCH_RESULT.imageurl %]" >title="[% SEARCH_RESULT.description %]" style="float: left; margin: .1em;" >alt="" /> >- [% END %] >- [% END %] >- > [% IF ( SEARCH_RESULT.author ) %] > <a > href="/cgi-bin/koha/catalogue/search.pl?idx=au&q=[% SEARCH_RESULT.author > |url %]" title="Search for this Author">[% SEARCH_RESULT.author %]</a> > [% ELSE %] >-- >2.1.4 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
