https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #16 from Ere Maijala <[email protected]> --- I like this approach quite a bit. A couple of comments: 1.) Incomplete fields should be handled more gracefully. I'm getting a set of these warnings: substr outside of string at /home/ere/kohacommunity/Koha/SearchEngine/Elasticsearch.pm line 356. This is with the test records from https://github.com/joubu/koha-misc4dev/tree/master/data/sql/marc21/1611/after_17196 2.) es_id is missing from the indexed records compared to the Catmandu indexing code. Is this intentional? 3.) I think this, when done, should just replace the Catmandu-based indexing code. Since the ES support itself is somewhat experimental, it would make sense to switch once and for all. 4.) Make sure to document the dependency on Search::Elasticsearch. Would it be possible to use the v6 module? It says it supports ES 5 too. I had to downgrade it on my system for the patch to work. 5.) Booleans should be indexed as true/false. I'm seeing deprecation notices for suppress and onloan (this is wrong in the old code too, but could as well be done correctly here). 6.) The Catmandu version seems to create way more __sort fields, but perhaps it's a bug in the Catmandu version? 7.) The patch doesn't apply cleanly, so there could be also something I screwed up while fixing it manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
