https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate CC| |[email protected] | |ommunity.org Status|Passed QA |Failed QA --- Comment #43 from Jonathan Druart <[email protected]> --- Few things: 1. get_routinglists should not be get_routing_lists instead? 2. changes to C4::Auth are not needed, since bug 18403 we have a logged_in_user Koha::Patron sent to the template (from C4::Auth, so we have access to it from everywhere). Yes, it's awesome :) So from the template: [% IF logged_in_user && logged_in_user.get_routing_lists.count %] should do the trick. 3. Koha::Patron->get_routing_lists should return the ->search result directly, to let callers use it in scalar or list context. 4. Koha::Subscription::RoutingList->subscription should use DBIC relationship: return Koha::Subscription->_new_from_dbic($self->_result->subscriptionid); 5. "your routing lists" tab is not marked as "active" when needed (routinglistview vs routinglistsview) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
