https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
--- Comment #35 from Katrin Fischer <[email protected]> --- Comment on attachment 72088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72088 Bug 2696 - Fine Payments Should Show What Was Paid For Review of attachment 72088: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=2696&attachment=72088) ----------------------------------------------------------------- Hi all, looking at how long we've wanted for this... wow. While testing I discovered several issues with the template variables that I am fixing in a QA follow-up. ::: Koha/Account/Offset.pm @@ +37,5 @@ > =cut > > +=head3 debit > + > +=cut 1) Please add POD to debit and credit! Not treating this as a blocker, but please provide a follow up. ::: koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc @@ +1,2 @@ > +[% SWITCH account_offset.type %] > + [% CASE 'Payment' %]Payment 2) I've checked and the strings from account_offset_type.inc and accounttype.inc are picked up by translation scripts. Just a note, nothing to see here! ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt @@ +84,5 @@ > + <th>Amount</th> > + <th>Amount outstanding</th> > + <th>Type</th> > + <th>Note</th> > + <th>Transacting<br/>librarian id</th> 3) This is a translation issue, because it leaves you with "Transacting" and "library id" separately. We need to achieve a nice layout otherwise. I will remove the <br> in a QA follow-up. ::: members/accountline-details.pl @@ +18,5 @@ > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +use Modern::Perl; > + > +use CGI; 4) Should be: use CGI qw ( -utf8 ); -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
