http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2865
Chris Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8460|0 |1 is obsolete| | --- Comment #7 from Chris Hall <[email protected]> --- Created attachment 9212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9212&action=edit corrects errors in acquisitions calculations Attached patch that meets clients specs, not ready to be up streamed yet. Hey Katrin You understood correctly, it assumes budgeted cost is GST exclusive so this can't be pushed to master yet. Just for documentation purposes, here is what I used the various variables to mean: list price = may or may not include gst depending on vendor settings, if there if a discount then this price hasnt been adjusted to reflect the discounted price. unit price = actual cost, user supplied, not used in calculations rrp = gst exclusive, also doesnt reflect discounted price ecost = budgeted cost = list price minus any discount and excluding gst gstrate = rate of gst as a percentage gst = rrp * gstrate The previous code used gst to refer to both the rate and the actual amount in different places, I have corrected this where I came across it. Work to be done: Setting for whether or not the budgeted cost is gst inclusive/exclusive. This is the previous issue Katrin pointed out still exists, see line 323 or acqui/parcel.pl, I have labeled this with a FIXME as this assumes tototal is gst exclusive and will always add it back in. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
