https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
David Gustafsson <glask...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |glask...@gmail.com
--- Comment #28 from David Gustafsson <glask...@gmail.com> ---
Nice work. I was unable to apply patch using git bz apply, getting:
error: sha1 information is lacking or useless
(Koha/SearchEngine/Elasticsearch/QueryBuilder.pm).
error: could not build fake ancestor
Am I doing something wrong or is there an issue with the current patches?
I also have some questions/suggestions:
1) I find it slightly confusing that "weight" is in the patch whilst "boost" is
used in elastic. Not a big deal at all, but would be nicer to use the same
terminology as Elastic imho.
2) Weight/boost should be decimal, for example DECIMAL(5,2) should be more than
enough precision.
3) Why not use field boosting in advanced search? As a user I would find it
confusing to get different results performing the same search in both
interfaces.
4) It seems like field boosts/weights specified in mappings.yaml will not be
picked up, this could be added in reset_elasticsearch_mappings in
Elasticsearch.pm.
I can contribute patches for some or all of the above s depending on which ones
are deemed good suggestions once I am able to apply the current patch.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
