https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600
Magnus Enger <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |[email protected] --- Comment #4 from Magnus Enger <[email protected]> --- There is a problem with the status_name variable. The error in the Chromium console is this: Uncaught ReferenceError: status_name is not defined at getStatusName (ill-requests.pl:674) at createStatus (ill-requests.pl:649) at jquery.dataTables.min.js:18 at Object.b.fnGetData (jquery.dataTables.min.js:12) at B (jquery.dataTables.min.js:16) at Ia (jquery.dataTables.min.js:14) at mb (jquery.dataTables.min.js:66) at T (jquery.dataTables.min.js:30) at ia (jquery.dataTables.min.js:48) at HTMLTableElement.<anonymous> (jquery.dataTables.min.js:95) status_name is defined on line 281, and used again on line 309: 277 // Render function for request status 278 var createStatus = function(data, type, row, meta) { 279 var origData = meta.settings.oInit.originalData; 280 if (origData.length > 0) { 281 var status_name = meta.settings.oInit.originalData[0].capabilities[ 282 row.status 283 ].name; 284 return getStatusName(status_name); 285 } else { 286 return ''; 287 } 288 }; 289 290 var getStatusName = function(origName) { 291 switch( origName ) { 292 case "New request": 293 return _("New request"); 294 case "Requested": 295 return _("Requested"); 296 case "Requested from partners": 297 return _("Requested from partners"); 298 case "Request reverted": 299 return _("Request reverted"); 300 case "Queued request": 301 return _("Queued request"); 302 case "Cancellation requested": 303 return _("Cancellation requested"); 304 case "Completed": 305 return _("Completed"); 306 case "Delete request": 307 return _("Delete request"); 308 default: 309 return status_name; 310 } 311 }; I think it should either be declared outside the function that starts on line 278, or status_name on line 309 should really be origName? Also, there is a mismatch between some of the names used in the "Filters" box and those used in the table: Date modified = Updated on Pickup branch = Library(?) Borrower card number = Patron barcode This will be a really good enhancement! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
