https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724
Victor Grousset/tuxayo <victor.grous...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75221|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor.grous...@biblibre.com> --- Created attachment 75307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75307&action=edit Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns We need to call Koha::Hold->set_waiting to correctly calculate the expiration date. It fixes a regression introduced by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures The expiration date has to be set for waiting holds == Test plan (time to execute: less than 4min) == 1. Set ReservesNeedReturns to "Don't automatically" 2. Place a hold on a specific item 3. Check it in and confirm hold 4. The hold should have an expiration date record page → Hold → "Expiration" column 5. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 6. Set ReservesNeedReturns to "Automatically" 7. Place a hold on a specific item (which should also behave like we check the item in to keep it for the patron) 8. The hold should have an *empty* expiration date record page → Hold → "Expiration" column 9. Holds awaiting pickup page should crash staff:/cgi-bin/koha/circ/waitingreserves.pl 10. Cancel the hold to remove the corrupted data record page → Hold → the red X 11. Apply this patch 12. Place a hold on a specific item 13. The hold should have an expiration date (not empty) 14. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 15. Celebrate! Signed-off-by: Victor Grousset <victor.grous...@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/