Marcel de Rooy <> changed:

           What    |Removed                     |Added
  Attachment #70424|0                           |1
        is obsolete|                            |
  Attachment #70425|0                           |1
        is obsolete|                            |

--- Comment #34 from Marcel de Rooy <> ---
Created attachment 75394
Bug 18856: Don't show cancel option for waiting holds in OPAC

This is the alternative patch of Kyle's
If a hold is 'waiting' for the patron to collect then the patron should
be prevented from cancelling the hold via their account in the opac.
If a patron tries to cancel the hold, Koha will give an 'are you sure'
alert and when you click Yes the page just refreshes and the hold
Staff can cancel the hold from the staff interface but they can then
action the waiting hold.
I think therefore that it is correct behaviour that a patron cannot
cancel a hold when it reaches waiting state via the opac but it would be
useful to either have a warning to prevent the cancellation or a useful
message when they attempt to do so.

The template was using a method that tells Koha if *staff* can cancel a
instead of patron.

Test Plan:
1) Set up a waiting hold
2) Try to cancel it from the opac
3) Note you cannot
4) Apply this patch
5) Reload the page
6) Note the cancel button has disappeared for found holds

It sounds better to keep the ->is_cancelable method, for readability

Signed-off-by: Kyle M Hall <>

Signed-off-by: Marcel de Rooy <>

You are receiving this mail because:
You are watching all bug changes.
Koha-bugs mailing list
website :
git :
bugs :

Reply via email to