https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778
Alex Arnaud <alex.arn...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #6 from Alex Arnaud <alex.arn...@biblibre.com> --- (In reply to Marcel de Rooy from comment #5) > I think we are not adding consistency in this script by removing a confirm > from one of the js functions in a row of similar ones. > Should you remove the other confirmation perhaps ? > > If you have confirm_deletion as name, I would expect a confirm there too. Hello Marcel, Not sure to understand what you are expecting. If i remove the 2 others JS confirmation (for closing and reopening), we have no more confirmation at all. I did it for deleting because there is an other one after. So the JS one is useless. Other possibility is to remove the one after JS for subscription deletion. I agree that this BZ is for fixing subscription deleting. Not for removing a useless confirmation. So i can just do what it is expected for -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/