https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
--- Comment #79 from Jonathan Druart <[email protected]> --- Some more QA comments, I have not checked if previous requests have been addressed. 1. Bug - add or edit a patron and add 2 fathers, one from an existing patron and the other not. Only 1 is saved. 2. On the edit patron view, the "Delete" checkbox does not have the correct label (i.e. when you click on it, it will not check/uncheck the checkbox). (related to comment 52, 2/) 3. a. It is not clear to me why you removed the contact* fields from the borrowers table. It looks like they were also used when no guarantor existed. b. Moreover `git grep contactfirstname|grep -v altcontactfirstname` returns occurrences that should be removed (if we really want to remove them) c. The fields are not removed from borrowermodification and deletedborrowers (from the atomic update) d. IMPORTANT - Should not we finally keep these fields and force the guarantors to be existing patrons? We could have only 1 "contact" and several guarantors. It seems that it will simplify a lot the code (for instance Koha::Patron->guarantors would return Koha::Patrons, and Koha::Patron::Relationship[s] would stay simple Koha::Object[s]) 4. Should not the table name "relationships" be more specific? ("borrower_relationships"?) 5. add_guarantors should be moved to Koha::Patron 6. Koha::Patron->siblings is weird, we should not need to refetch the patron list. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
