https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968
--- Comment #11 from Kyle M Hall <[email protected]> --- > 4) I'm not clear whether you're suggesting we should ditch the > intranet_catalog_biblio_enhancements method entirely. I don't think we can > do this as we need to be able to test in plugins-home.pl/.tt for plugins > that are within this class. If you just meant I should drop it from > detail.pm as mentioned in 2), yes, I will do this. I didn't fully understand it's purpose at first. What you've done in the followup is excellent. I've added to more patches for you, one that add's those unit tests, and another that renames get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button I know that's quite wordy, but it keeps the naming convention to be in line with the naming convention for the opac payment methods. If you these followups work for you, I think we'll be good to go! Just sign off on my patches, I'll sign off on yours and we can let someone else QA. Once it's passed qa, I'll add those methods to the Kitchen Sink plugin as well! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
