https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Martin Renvoize <martin.renvo...@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #23 from Martin Renvoize <martin.renvo...@ptfs-europe.com> ---
Sorry Nick, although I don't like the way this is done I would Pass QA on it as
there's already precedent and we can refactor it once there's been discussion
on bug 11983.

Failing QA for because there's a fair number of issues reported by the QA
script instead:

OK     Koha/Patrons.pm                                                          
 FAIL   misc/cronjobs/update_patrons_category.pl                                
   FAIL   critic                                                                
                "$min_dob" is declared but not used at line 157, column 1.
Unused variables clutter code and make it harder to read.                       
                "$au" is declared but not used at line 155, column 1. Unused
variables clutter code and make it harder to read.                              
                "$max_dob" is declared but not used at line 158, column 1.
Unused variables clutter code and make it harder to read.                       
                "$ao" is declared but not used at line 156, column 1. Unused
variables clutter code and make it harder to read.                              
   FAIL   forbidden patterns                                                    
                forbidden pattern: Data::Dumper::Dumper (line 189)              
   FAIL   valid                                                                 
                Global symbol "$ageunder" requires explicit package name (did
you forget to declare "my $ageunder"?)                                          
                Global symbol "$ageover" requires explicit package name (did
you forget to declare "my $ageover"?)                                           
                misc/cronjobs/update_patrons_category.pl had compilation
errors.                                                                         

 OK     t/db_dependent/Patrons.t                                                

Processing additional checks                                                    

        * Commit title does not start with 'Bug XXXXX: ' - a25919ad28

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to