https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031

--- Comment #15 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
QA Comment:
Thanks David. Improving parts not touched by most users (Debian/Plack).

Just a few remarks (close to nitpicking):
[1] A difference with the rule in shared-opac-plack is that you do not include
the PT flag. Note that this is fine. You do not need the PT flag since you have
the rule in a <Directory> section. (The PT flag is implied in per-directory
contexts.)
[2] The implicit PT may explain why you got the two additional lines in the
apache trace. Might be possible to finetune that, but needs more Apache
background.
[3] The rule is a bit hybrid. As you explained, it is in the context of a
RewriteBase with /api/. So paths are relative. But the replacement is not
relative but absolute. No reason to change, but a relative replace without /api
in front would have looked good to me too.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to