https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325
Charles Farmer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Charles Farmer <[email protected]> --- (In reply to M. Tompsett from comment #7) > Why have an enabled AND length? If the length is 0, then what is the point > of enabled? I agree with you, we definitely could get rid of the property if the BarcodePaddingLength's description makes it clear that a value of 0 disables that part of the code. (In reply to Julian Maurice from comment #9) > Why new system preferences ? Shouldn't it be configurable at the layout > level ? It depends. If you have multiple employees doing this repeatedly, and you wanna make sure everything prints out the same way every time, it makes sense to offer a syspref instead of forcing users to enter values over and over, especially if the defaults aren't what they need. Usability-wise, I think there's merit to the sysprefs, but I can see why someone who prints barcodes once every blue moon wouldn't want to clutter its database with additional preferences. --- I did an in-between for now: removed the BarcodePaddingEnable pref, and changed the BarcodePaddingLength's description to imply that a value of 0 disables padding. If you say three times that the sysprefs have to go, I'll make it configurable at the template level. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
