https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443
--- Comment #3 from Martin Renvoize <martin.renvo...@ptfs-europe.com> --- First QA comment.. and it's possibly a little mean.. You've introduced three 'filter_by_' methods: Awesome++. However, there's an inconsistency with their chainability.. I personally feel such a method should always allow chaining and as such would request, although currently, you don't use them within a chain, that `filter_by_attribute_type` and `filter_by_attribute_value` are altered such that they act upon self rather than instantiating a new object to pass as the return. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/