Katrin Fischer <> changed:

           What    |Removed                     |Added
             Status|Signed Off                  |Failed QA

--- Comment #88 from Katrin Fischer <> ---
Giving this a go, any help/more eyes much appreaciated!

1) Questions

1.1) >This will allow to configure the way the simple search is weighted: 
>it will search in all fields for which a weight has been indicated. 
>If no weight was indicated it will search in all fields. (In addition, 
>this allows excluding some search fields from the simple search!)

>From comments#13+ I tihnk this is no longer the case and it will be
always searched on all fields + boosting the weighted fields.
Can you confirm?

1.2) Should the patches on this bug tested in combination with
other patches from dependent bugs? A more detailed test plan would help
me a lot.

1.3) Could we deliver this with a basic default weighting?

2) QA tools and unit tests

2.1) FAIL       t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     spelling
   FAIL   valid
                You tried to plan twice 

2.2) When I remove the doubled up line, the test still fails:

t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. Dubious, test
returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests 

Test Summary Report
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t (Wstat: 65280
Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 2 tests but ran 0.
Files=1, Tests=0,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.23 cusr  0.05
csys =  0.30 CPU)
Result: FAIL
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ vi
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. 1/3     # No
tests run!

#   Failed test 'No tests run for subtest "build_query with weighted fields
#   at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 167.
Can't locate object method "new" via package "t::lib::TestBuilder" (perhaps you
forgot to load "t::lib::TestBuilder"?) at
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 127.
# Looks like your test exited with 255 just after 3.
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. Dubious, test
returned 255 (wstat 65280, 0xff00)
Failed 1/3 subtests 

2.3) * Commit title does not start with 'Bug XXXXX: ' - dfe2ab9

2.4) Other tests fail too:

t/db_dependent/Koha/SearchField.t .. 1/15 
#   Failed test 'Title weight is 25.'
#   at t/db_dependent/Koha/SearchField.t line 196.
#          got: '25.00'
#     expected: '25'

#   Failed test 'Subject weight is 15.'
#   at t/db_dependent/Koha/SearchField.t line 198.
#          got: '15.00'
#     expected: '15'

#   Failed test 'Author weight is 5.'
#   at t/db_dependent/Koha/SearchField.t line 200.
#          got: '5.00'
#     expected: '5'
# Looks like you failed 3 tests of 15.
t/db_dependent/Koha/SearchField.t .. Dubious, test returned 3 (wstat 768,
Failed 3/15 subtests 

3) Code Review

3.1) Please use AFTER/BEFORE to make sure the column ends always in the correct
+        $dbh->do( "ALTER TABLE `search_field` ADD COLUMN `weight` decimal(5,2)

3.2) Can you explain this line?
<input type="hidden" name="advsearch" value="1"/>

4) Further tests

Adding, deleting and editing weights works. Waiting for follow-up and more info
before I continue!

You are receiving this mail because:
You are watching all bug changes.
Koha-bugs mailing list
website :
git :
bugs :

Reply via email to