https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21230
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77837|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <[email protected]> --- Created attachment 77901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77901&action=edit Bug 21230: Prevent Reserves.t to fail randomly The following test can fail if the hold has been generated with found => 'W': # Failed test 'No tests run for subtest "_koha_notify_reserve() tests"' # at t/db_dependent/Reserves.t line 675. Can't call method "to_address" on an undefined value at t/db_dependent/Reserves.t line 661. # Looks like your test exited with 255 just after 56. We should call AddReserve instead. Test plan: 0. Do not apply this patch 1. Do the following change: my $hold = $builder->build({ source => 'Reserve', value => { borrowernumber=>$hold_borrower, found => 'W', # This line is added, do not forget the comma above } }); 2. Prove it makes the test fail 3. stash the changes and apply this patch 4. Make sure the tests pass Signed-off-by: Kyle M Hall <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
