https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639
--- Comment #20 from Katrin Fischer <[email protected]> --- Some notes from reading through the bug and code review: 1) Leftover warn in finishreceive.pl +$replacementprice = Koha::Number::Price->new( $replacementprice )->unformat(); +warn "Replacement $replacementprice"; 2) Database update I also wonder if we should prefill replacementprice from rrp. We could argue that not all libraries will want it to be set to rrp by default, especially as it would change the behaviour for pending orders. 3) Notes for for the release notes would be great. Nick? 4) Question: Why not allow editing of retail price later on? In case of a typo you'd have to reopen the basket and that will mess with the order dates and such... wouldn't it be easier to leave it editable? I can remove the warn in a follow-up, still have to finish testing of the behaviour and calculations. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
