https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #6 from Marcel de Rooy <[email protected]> --- QA Comment: Looks good! Nice addition. Some minor comments which should take much time: manage_classifications No text on form? => typo CASE 'manage_classfications' Missing letter ! Spelling Manage column configuation / SRU server confiugration / search enginge installer/data/mysql/atomicupdate/bug14391_granular_admin_permissions.sql The atomic update queries could be further optimized. You add separate inserts for each permission with subqueries for borrowers. Easy to read, but more costly to run. Do you have figures about how long it takes on a larger patron table ? Why not something like: INSERT INTO user_permissions (borrowernumber, module_bit, code) SELECT borrowers.borrowernumber, permissions.module_bit, permissions.code FROM borrowers LEFT JOIN user_permissions USING (borrowernumber) LEFT JOIN permissions ON module_bit =3 AND code NOT IN ( * list existing permissions for admin * ) WHERE user_permissions.code='parameters_remaining_permissions' This replaces most separate inserts and uses joins instead of subqueries. admin/localization.pl, svc/localization Need manage_itemtypes Understand why you do it, but it seems not logical in the long run. Better add a specific one. admin/printers.pl parameters => '*' Only case where we refer to *. Why not separate? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
