https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77961|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <[email protected]> --- Created attachment 78111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78111&action=edit Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with my $barcode = Koha::Items->find($itemnumber)->barcode; But if we are not sure that the item exists, we should test the return of ->find before ->barcode Test plan: - Edit an item - Check an item in - Test SIP - I do not really know how to trigger that code, apparently misc/sip_cli_emulator.pl does not deal with holds. Any ideas? Signed-off-by: Josef Moravec <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
