https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- This is working well for me and is a really nice addition. Wondering 2 things: - We got a system preference for turning on/off patron attributes. Should the column not be visible when the pref is turned off? (ExtendedPatronAttributes) - The display_value method somehow looks not quite right to me. I think this may be what Jonathan was trying to point out in his comment, that there could be another way of doing it. Could you take a look and comment? I rebased the patch for testing, I will attach the rebased patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/