https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036
--- Comment #9 from Marcel de Rooy <[email protected]> --- (In reply to M. Tompsett from comment #8) > Comment on attachment 76702 [details] [review] > Bug 21036: Fix warnings from C4/Biblio > > Review of attachment 76702 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Biblio.pm > @@ +2324,4 @@ > > if ( ( @$tags[$i] ne $prevtag ) ) { > > $close_last_tag = 0; > > $j++ unless ( @$tags[$i] eq "" ); > > + my $str = ( $indicator->[$j] // q{} ) . ' '; # extra space > > prevents substr outside of string warn > > Shouldn't this be two spaces? just because substr(' ',1,1) doesn't explode, > doesn't mean you shouldn't hand it a nice string. This seems to be nice enough ;) Since $str goes directly into _default_ind_to_space, it really does not matter. But I do not mind adding a space.. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
