https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887
--- Comment #104 from Josef Moravec <[email protected]> --- Comment on attachment 78746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78746 Bug 18887: Add Koha::CirculationRule(s) Review of attachment 78746: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18887&attachment=78746) ----------------------------------------------------------------- ::: Koha/CirculationRule.pm @@ +26,5 @@ > +use Koha::ItemTypes; > + > +=head1 NAME > + > +Koha::Hold - Koha Hold object class C & P mistake ::: Koha/CirculationRules.pm @@ +27,5 @@ > +use base qw(Koha::Objects); > + > +=head1 NAME > + > +Koha::IssuingRules - Koha IssuingRule Object set class C & P mistake @@ +47,5 @@ > + my $categorycode = $params->{categorycode}; > + my $itemtype = $params->{itemtype}; > + my $branchcode = $params->{branchcode}; > + > + croak q{No rule name passed in!} unless $rule_name; Please use Exception instead of croak @@ +85,5 @@ > + unless exists $params->{itemtype}; > + croak q{set_rule requires the parameter 'rule_name'!} > + unless exists $params->{rule_name}; > + croak q{set_rule requires the parameter 'rule_value'!} > + unless exists $params->{rule_value}; Please use Exception instead of croak -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
