https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023

--- Comment #11 from Jonathan Druart <[email protected]> 
---
Comment on attachment 79204
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79204
Bug 20023: (QA follow-up) Tiny simplification

Review of attachment 79204:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20023&attachment=79204)
-----------------------------------------------------------------

::: opac/opac-password-recovery.pl
@@ +73,4 @@
>          $errMultipleAccountsForEmail = 1;
>      }
>      elsif ( $borrower = $search_results->next() ) {    # One matching 
> borrower
> +        my @emails = grep { $_ && !/^\s+$/ } ( $borrower->email, 
> $borrower->emailpro, $borrower->B_email );

Not sure this is simplification :)

@@ +77,2 @@
>  
> +        my $firstNonEmptyEmail = @emails ? $emails[0] : undef;

So simplify it, really :)
  my $firstNonEmptyEmail = shift @emails;

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to