https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941
--- Comment #4 from Josef Moravec <[email protected]> --- Comment on attachment 79577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79577 Bug 20941: Add Illrequest->getType method Review of attachment 79577: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20941&attachment=79577) ----------------------------------------------------------------- ::: Koha/Illrequest.pm @@ +724,4 @@ > || ""; # "the empty prefix" > } > > +=head3 getType should be get_type, or maybe better get_material_type, please rename the method @@ +734,5 @@ > + > +sub getType { > + my ($self) = @_; > + my $attr = $self->illrequestattributes->find({ type => 'type'}); > + return $attr ? $attr->value : '<span>N/A</span>'; We should return implicit undef if no type is set and then handle it in templates. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
