https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512
Bug ID: 21512
Summary: CalculateFinesOnReturn doesn't work without the
syspref finesMode
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected], [email protected]
Fines are not created for checking in an Item, if the syspref
'CalculateFinesOnReturn' is enabled without the syspref finesMode being in the
'production' -mode (Calculate and charge).
CalculateFinesOnReturn must work without the fines.pl -feature.
The problem is with the subroutine C4::Circulation::_CalculateAndUpdateFine()
Initially it looks like it must be invoked from the fines.pl as well. But that
subroutine is only used within the C4::Circulation module for AddRenew and
AddReturn.
Hence the _CalculateAndUpdateFine() has nothing to do with fines.pl|finesMode.
This patch replaces the finesMode-check with CalculateFinesOnReturn-check.
I am not sure why there needs to be a specific syspref for the fines.pl, or why
CalculateFinesOnReturn is needed, as the fine amounts can be tweaked using the
circulation rules matrix and the fines.pl-cronjob can either be ran, or not,
with an endless possibility of parameters that shouldn't be in the sysprefs.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
