https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337

--- Comment #17 from Jonathan Druart <[email protected]> 
---
I have fixed a failing test in Objects.t

IMO the following line is wrong:
  $patron->delete == 1 || Koha::Exceptions::Patron::Delete->throw;

We must follow dbic behaviours and so we must not throw an exception if
something went wrong (what DBIC does)

Then I would not name an exception "Koha::Exceptions::Patron::Delete" but more
something like Koha::Exceptions::Patron::NotDeleted, or CannotDelete,
CannotBeDeleted, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to