https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Jonathan Druart <[email protected]> --- Quick code review: 1. + my $library = Koha::Libraries->find($borrower->branchcode)->unblessed; can be replaced by $patron->library 2. "lang" param must be passed to GetPreparedLetter to make the notice translatable 3. Use "patron" instead of "borrower", especially for Koha:: 4. + to_address => $borrower->email, To not enqueue with to_address, it must depend on AutoEmailPrimaryAddress. It is correctly handled when sent. 5. We will need native English speaker for "NotifyToReturnItemFromLibrary" (name, description, options) 6. Code in borrowers_to_satisfy could be simplify (no blocker, I can have a look later) 7. New template notices must use the TT syntax (I would recommend to provide the notice for 'en' only and wait for the QA stamp to provide the changes to other files) 8. Changes to AddReserve is not covered by tests. Maybe it should be moved to Koha::Hold? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
