https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21475
--- Comment #9 from Julian Maurice <[email protected]> --- Comment on attachment 80595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80595 Bug 21475: Fix crash on missing default itemtype Review of attachment 80595: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21475&attachment=80595) ----------------------------------------------------------------- ::: opac/opac-detail.pl @@ +762,5 @@ > my $artreqpossible = $patron > ? $biblio->can_article_request( $patron ) > + : $itemtype > + ? $itemtype->may_article_request > + : q{}; I think it's odd to return an empty string for what seems to be a boolean value. I can see that can_article_request and may_article_request do the same thing so it's consistent. But why not return simply 0 (as 1 is used for the true value) ? And why q{} instead of just '' ? Is there some kind of consensus about this that I'm not aware of ? (Note that this will not block QA, I'm just curious) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
