https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Joonas Kylmälä <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #163 from Joonas Kylmälä <[email protected]> --- (In reply to David Gustafsson from comment #160) > Created attachment 80971 [details] [review] > Bug 19893: Add pods, remove syspref, add tests for serialization format > > Add missing pods, remove obsolete syspref and add test for serialization > format for records exceeding max record size Thanks for the patch! :) Couple comments (I have to go now, continuing review hopefully later): 1. There is typo databse and missing to. "Using mappings stored in databse convert" -> "Using mappings stored in database to convert" 2. It appears there are many different changes but they have been put to one commit. It would make it easier to review if the changes were in their own commits with their own commit messages. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
