https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #16 from Kyle M Hall <[email protected]> --- Comment on attachment 80882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80882 Bug 21610: Fix integers and dates values at Koha::Object->store level Review of attachment 80882: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21610&attachment=80882) ----------------------------------------------------------------- ::: Koha/Object.pm @@ +308,5 @@ > + 'date', > + 'datetime' > + ); > + > + return ( grep { $column_type eq $_ } @dt_types) ? 1 : 0; I think this may be quite inefficient as it uses grep. Perhaps we could use https://perldoc.perl.org/List/Util.html#any instead? Or just a set of ternary operators or elsifs if we really want to keep it fast and simple. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
