https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #102 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Code review: 1. Not important but the Koha.po file provided for the tests are not taken into account. Maybe it could be better to generate the .mo from the tests? 2. No tests provided for misc/translator/LangInstaller.pm - I would not consider it as blocker as it is the current state. 3. The content from the .inc files are added to the .po because they contain TT blocks on several lines. Maybe we should have a list of files to skip and copy as it (?) 4. What is done in Koha::I18N::init is weird, but I trust you if you think everythink is needed. However: pod Locale::Messages, nl_putenv: "The sole purpose of this function is to work around some ideosyncrasies in the environment processing of Windows systems. If you want to portably set or unset environment variables, use this function instead of directly manipulating %ENV." So maybe we should use ENV, it will make the line clear about what it does, and 'git grep $ENV' will work -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
