https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #175 from Nick Clemens <[email protected]> --- (In reply to Joonas Kylmälä from comment #174) > (In reply to David Gustafsson from comment #173) > > I agree It might benefit from documentation, it should (or even can) not be > > moved outside though, since I think there are some closures within. It is > > also a specific and private helper-method, thus belongs inside the method. > > I couldn't see any closures in the two subroutines I mentioned (and with > "closure" I mean they don't refer to any variables in the outer subroutine). > The search functionality and indexing seemed to work fine also when they are > in the top level (I tested). Anyways, I put this topic on the Koha developer > meeting list and maybe we will get a better consensus on how to do this. The general consensus at the meeting was that seemed like ti could be a better function on its own and that the nesting was confusing in this case and didn't seem to be a traditional closure. The subroutine should be moved to the top level -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
