https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912
--- Comment #14 from Katrin Fischer <[email protected]> --- Starting here with QA script and code review: 1) QA Script FAIL t/db_dependent/Circulation.t OK critic OK forbidden patterns OK git manipulation OK pod FAIL spelling calulated ==> calculated OK valid FAIL t/db_dependent/Koha/ItemTypes.t OK critic OK forbidden patterns OK git manipulation OK pod FAIL spelling calulated ==> calculated OK valid 2) Code review 2.1) <span class="hint">This fee is charged a checkout/renewal time for each day between the checkout/renewal date and due date.</span> ==> charged at... 2.2) Why the check on notforloan? What if the notforloan is overriden? + <td> + [% UNLESS ( itemtype.notforloan ) %] + [% itemtype.rental_charge_daily | $Price %] + [% END %] + </td> 3) Tests Circulation.t needs to be updated to run 120 tests (not 119) There is a new warn in the other tests: t/db_dependent/Koha/ItemTypes.t .. 23/25 Use of uninitialized value in string eq at /home/vagrant/kohaclone/Koha/ItemType.pm line 43. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
