https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Marcel de Rooy <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #34 from Marcel de Rooy <[email protected]> ---
(In reply to Ere Maijala from comment #33)
> (In reply to M. Tompsett from comment #32)
> > ::: C4/Biblio.pm
> > @@ -310,4 @@
> > >  
> > >      $frameworkcode = "" if !$frameworkcode || $frameworkcode eq 
> > > "Default"; # XXX
> > >  
> > > -    _strip_item_fields($record, $frameworkcode);
> > 
> > I really think removing the frameworkcode is a bad idea.
> 
> The default framwork was made authoritative in bug 19096. As a result of
> that, the frameworkcode parameter in GetMarcFromKohaField function is no
> longer used. _strip_item_fields is still using GetMarcFromKohaField, it just
> doesn't need the frameworkcode for anything. So effectively the patch just
> removes an unused parameter.

Yeah still writing that patch :)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to