https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814

Julian Maurice <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #3 from Julian Maurice <[email protected]> ---
Hi Owen,

Patch works as expected but shouldn't the margin be equal to (or at least based
on) the height of navbar ?

For the navbar we have

min-height: 20px

but it's actually a bit more (30.4px for me) and the patch sets a margin of
3em.

I'm not familiar with SCSS, but this looks like a good candidate for variables.
Something like this:

:root {
  $navbar_height: 30px;
}
.navbar {
  height: $navbar_height;
}
.main {
  margin-bottom: $navbar_height;
}

What do you think ?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to