https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261

--- Comment #6 from Janusz Kaczmarek <[email protected]> ---
(In reply to Janusz Kaczmarek from comment #5)
> Did you check the impact of the patch on zebra searches? It seems that
> removing the line:
> 
> my $offset = ( $startfrom - 1 ) * $resultsperpage + 1;
> 
> leads to improper behavior of Koha when switching to subsequent pages of
> result set when zebra is used as a search engine: instead of jumping forward
> every 20 (or whatsoever) entries it moves forward by one entry only.

NB. a similar line is to be found in authorities/auth_finder.pl (line 81 in
18.05.06): 

my $offset = $startfrom * $resultsperpage;

and works OK with zebra and search_auth_compat.

The difference is that the pages are counted 1-base in authorities-home.pl and
0-based in auth_finder.pl.

Does this line not harm ES searches?  If not why not unify the mode of
operation and make authorities-home.pl 0-based with the initial phrase $offset
= $startfrom * $resultsperpage ?  Would it be OK for ES?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to