https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #9 from Andrew Isherwood <[email protected]> --- OK, well, now I'm really confused. Looking in api/v1/swagger/paths/illrequests.json (https://github.com/PTFS-Europe/koha/blob/master/api/v1/swagger/paths/illrequests.json#L7-L95), the "parameters" object has a bunch of possible parameters, borrowernumber being one of them. Which explains why adding this parameter without modifying the spec didn't break things. However, with the exception of "embed" and "borrowernumber" there's no handling in the API endpoint controller for these parameters. It looks like the majority have been in the spec since the ILL work was originally done, which suggests to me a misunderstanding of how the spec works. So, in short, we don't need to add "borrowernumber" to the spec since it's already there, but we should consider removing the extraneous parameters, though that feels like it's outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
