https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22006 --- Comment #19 from Jonathan Druart <[email protected]> --- (In reply to Devinim from comment #17) > (In reply to Jonathan Druart from comment #15) > > due_date must be displayed with the as_due_date flag, not with_hours: > > > > [% your_due_date | $KohaDates as_due_date => 1 %] > > Hi Jonathan, > > In order to make code integrity, we've looked at > members/readingrec.tt > Line 95 of that file also uses due_date. It is wrong :) IIRC due dates must be displayed using the as_due_date flag, to not show the time part if 23:59 (In reply to Devinim from comment #18) > (In reply to Jonathan Druart from comment #16) > > 2. As well, the html filter is not needed when already KohaDates filtered. > > 2. As similar to answer 1, some other files also use html filter like > reserve/request.tt > catalogue/issuehistory.tt It is because we removed the html filter when the $KohaDates occurrences were used without parameters. It is not a big deal anyway but we could avoid unnecessary processing removing these filters. I am going to deal with that on a separate bug report. > > 3. in printinvoice.pl > > > > +$accountline->{'item'} = $accountline->{itemnumber} ? > > $accountline_object->item : "" ; > > +$accountline->{'issue'} = $accountline->{issue_id} ? > > $accountline_object->issue : "" ; > > > > It read wrong, why not: > > $accountline->{item} = $accountline_object->item || "" ; > > $accountline->{issue} = $accountline_object->issue || ""; > > ? > > > 3. If you choose Create manual invoice tab and then select a type without > using a barcode number (like New Card), since there won't be an itemnumber > in accountline table, item object will give an error like ( DBIC result > _type isn't of the _type Item at > /home/vagrant/kohaclone/members/printinvoice.pl line 60) . It's a bug, I have opened bug 22006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 [Bug 22006] Koha::Account::Line->item should return undef if no item linked -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
