https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049
Owen Leonard <oleon...@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83543|0 |1 is obsolete| | Attachment #83548|0 |1 is obsolete| | Attachment #83549|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleon...@myacpl.org> --- Created attachment 83625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83625&action=edit Bug 22049: Make MarkIssueReturned rely on returndate only This patch changes the params accepted by C4::Circulation::MarkIssueReturned by removing the $dropbox_branch param. This passed branchcode was only used to initialize the Koha::Calendar object, but the date arithmetic has already taken place in a couple places before we reach this point. This logic needs to be simplified (bug 14591), and this is the starting point. To test: - Apply this patch - Run: $ git grep MarkIssueReturned => SUCCESS: Check all the uses of the function either originally passed undef, or now pass the same date that would've been calculated anyway, in the returndate param. - Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard <oleon...@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/