https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747

--- Comment #6 from Tomás Cohen Arazi <[email protected]> ---
(In reply to Martin Renvoize from comment #5)
> Created attachment 83252 [details] [review]
> Bug 21747: Use Koha::Account:: routines in UpdateFine
> 
> Set to use Koha::Account->add_debit and Koha::Account::Line->adjust
> 
> Known Side Effect: The format of the FinesLog, if enabled, is changed
> after this patch. Prior to this patch the $actionname was left undefined
> and the $infos field contained the string:
> 
> `"due=".$due."  amount=".$amount." itemnumber=".$itemnum`
> 
> After this patch, the logs are more consistent with other FINES logs,
> with an $actionname of 'CREATE' or 'UPDATE' and the $infos field
> containing a Dumper of fine data.
> 
> Signed-off-by: Josef Moravec <[email protected]>

I think we need to consider the backdated returns use case, and have another
offset for those, as fine_increment doesn't look right.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to