https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer <[email protected]> --- Hi Nick, coming back to this: QA scripts pass now (good!) Am I right that this is ES only? But: 1) There is an issue with the CSS files (please fix first of all): $ node_modules/.bin/gulp build --view=opac [14:17:24] Using gulpfile ~/kohaclone/gulpfile.js [14:17:24] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Error: Invalid CSS after "... solid #E3E3E3;": expected "}", was ".border-radius-all(" on line 3281 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> border: 1px solid #E3E3E3; -----------------------------------^ 2) Please add the link to the navigation (formerly 1). I feel it would make sense to have this depending on a system preference as the other additional features in the navigation bar do. It should also note that this is for Elasticsearch only. But beware: We already got OpacBrowser and OpacBrowseReults... (probably OpacBrowser should be renamed OpacBrowseAuthorities...). 3) opac-browse.pl doesn't use the standard use CGI qw ( -utf8 ); 4) Follow-up bug or something to resolve before pushing? +# This is the temporary entrance point to the API. Once bug #13799 is settled, +# it should be ported to using that. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
