https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21268
--- Comment #3 from Katrin Fischer <[email protected]> --- I tested a bit on master: the funds = 0 now show when adding a new order, but are for example not in the fund pull down on receiving the order. > acqui/addorderiso2709.pl: if ( !defined $r->{budget_amount} || > $r->{budget_amount} == 0 ) { > acqui/basket.pl: if (!defined $r->{budget_amount} || > $r->{budget_amount} == 0) { > acqui/booksellers.pl: if (!defined $r->{budget_amount} || > $r->{budget_amount} == 0) { > acqui/neworderbiblio.pl: if (!defined $r->{budget_amount} || > $r->{budget_amount} == 0) { > acqui/neworderempty.pl: if (!defined $r->{budget_amount} || > $r->{budget_amount} <0) { > acqui/orderreceive.pl: if ( !defined $r->{budget_amount} || > $r->{budget_amount} == 0 ) { > acqui/parcels.pl: if (!defined $r->{budget_amount} || $r->{budget_amount} > == 0) { > > > It's '== 0' vs '< 0' > > So we we should fix neworderempty and replace '<0' with '== 0' I am not sure what would be the right behaviour here. I think having to add 0.01 just to make a fund you want to use for handling 'free' orders is a bit clumsy right now. I wonder if the cleaner solution would be to just check if the fund exists and omit testing for the amount in all places. Or: Only test for negative with <0 everywhere. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
